linux-kernel - Re: [PATCH v2 03/22] KVM: x86: fix broken read emulation spans a page boundary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E0B0447.9030003@cn.fujitsu.com>
Date:	Wed, 29 Jun 2011 18:53:59 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Avi Kivity <avi@...hat.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 03/22] KVM: x86: fix broken read emulation spans a
 page boundary

On 06/29/2011 04:21 PM, Avi Kivity wrote:

>>
>> -    if (kvm_read_guest_virt(ctxt, addr, val, bytes, exception)
>> -        == X86EMUL_CONTINUE)
>> +    if (!kvm_read_guest(vcpu->kvm, gpa, val, bytes))
>>           return X86EMUL_CONTINUE;
> 
> This doesn't perform the cpl check.
> 

Firstly, it calls kvm_mmu_gva_to_gpa_read to translate gva to gpa, and cpl
is checked in this function, it is not enough?

> I suggest dropping this part for now and doing it later.
> 

OK, i will post this part in the separate patchset. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/