linux-kernel - Re: [PATCH] Add cloexec information to fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTim=whb61nbCTH-jH6cYdLrja8VCSQ@mail.gmail.com>
Date:	Thu, 30 Jun 2011 09:07:10 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ulrich Drepper <drepper@...adia.org>
Cc:	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	viro@...iv.linux.org.uk, wilsons@...rt.ca
Subject: Re: [PATCH] Add cloexec information to fdinfo

On Thu, Jun 30, 2011 at 6:39 AM, Ulrich Drepper <drepper@...adia.org> wrote:
>
> One more reason to at least not use the patch as you have it right now.
>  If a file descriptor was opened with O_CLOEXEC but subsequently the bit
> has been reset using fcntl() the f_flags value would still have the
> O_CLOEXEC bit set.

Umm. Look at my patch again. It masks the O_CLOEXEC bit *exactly*
because the bit is useless as it is now.

Which is why your previous objection was so silly too and I didn't
even bother replying to the blather. O_CLOEXEC at open time has no
special magical meaning. The only meaningful value for that bit is the
current one.

Which is exactly what my patch did.

> If you don't like the separate cloexec line, at least reset the
> O_CLOEXEC bit in the f_flags output if the FD_ISSET() test returns zero.

How about you just read the patch again?

This issue is closed as far as I am concerned. I repeat from my previous email:

  "I'm not going to commit it, but if others think this is a reasonable
   thing to do and remind me during the next merge window, we can
   do it then."

Gaah.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/