linux-kernel - Re: [PATCH] Add cloexec information to fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E0C7C95.4070803@akkadia.org>
Date:	Thu, 30 Jun 2011 09:39:33 -0400
From:	Ulrich Drepper <drepper@...adia.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	viro@...iv.linux.org.uk, wilsons@...rt.ca
Subject: Re: [PATCH] Add cloexec information to fdinfo

On 06/29/2011 10:59 PM, Ulrich Drepper wrote:
> It provides the information, yes, but it also hides some information.
> If you do it this way we cannot distinguish code which uses O_CLOEXEC at
> open-time from uses of fcntl(FD_CLOEXEC).

One more reason to at least not use the patch as you have it right now.
 If a file descriptor was opened with O_CLOEXEC but subsequently the bit
has been reset using fcntl() the f_flags value would still have the
O_CLOEXEC bit set.

If you don't like the separate cloexec line, at least reset the
O_CLOEXEC bit in the f_flags output if the FD_ISSET() test returns zero.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)