linux-kernel - Re: [PATCH resend] compat_ioctl: fix warning caused by qemu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201107011646.28918.arnd@arndb.de>
Date:	Fri, 1 Jul 2011 16:46:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Johannes Stezenbach <js@...21.net>
Cc:	Kevin Wolf <kwolf@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Jens Axboe <axboe@...nel.dk>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH resend] compat_ioctl: fix warning caused by qemu

On Friday 01 July 2011, Johannes Stezenbach wrote:
> 
> On Linux x86_64 host with 32bit userspace, running
> qemu or even just "qemu-img create -f qcow2 some.img 1G"
> causes a kernel warning:
> 
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(00005326){t:'S';sz:0} arg(7fffffff) on some.img
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(801c0204){t:02;sz:28} arg(fff77350) on some.img
> 
> ioctl 00005326 is CDROM_DRIVE_STATUS,
> ioctl 801c0204 is FDGETPRM.
> 
> The warning appears because the Linux compat-ioctl handler for these
> ioctls only applies to block devices, while qemu also uses the ioctls on
> plain files.
> 
> Signed-off-by: Johannes Stezenbach <js@...21.net>

Acked-by: Arnd Bergmann <arnd@...db.de>

> ---
> (resend with Cc: suggested by get_maintainer.pl)
> 
> discussed in http://lkml.kernel.org/r/20110617090424.GA19345@sig21.net
> 
> Arnd, is this what you had in mind, or did you mean to move
> all floppy compat definitions?  I decided to go with the
> minimal change.  Tested on both 2.6.39.2 and 3.0-rc5-63-g0d72c6f.

Yes, that should be fine, unless Jens would like to see a different
solution for the struct definitions, e.g. moving all of the floppy
compat ioctl numbers to fd.h. I'm fine with it either way.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/