linux-kernel - Re: [PATCH 2/5] input: twl6040-vibra: Do not use wrapper for irq request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110705112455.GB2820@legolas.emea.dhcp.ti.com>
Date:	Tue, 5 Jul 2011 14:24:56 +0300
From:	Felipe Balbi <balbi@...com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Liam Girdwood <lrg@...com>, Tony Lindgren <tony@...mide.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	Misael Lopez Cruz <misael.lopez@...com>,
	Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 2/5] input: twl6040-vibra: Do not use wrapper for irq
 request

Hi,

On Tue, Jul 05, 2011 at 12:14:23PM +0300, Peter Ujfalusi wrote:
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index dbf745d..1178c97 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -47,6 +47,7 @@ struct vibra_info {
>  	struct workqueue_struct *workqueue;
>  	struct work_struct play_work;
>  	struct mutex mutex;
> +	int irq;
>  
>  	bool enabled;
>  	int weak_speed;
> @@ -277,6 +278,13 @@ static int __devinit twl6040_vibra_probe(struct platform_device *pdev)
>  		goto err_kzalloc;
>  	}
>  
> +	info->irq = pdata->irq;
> +	if (!info->irq) {
> +		dev_err(info->dev, "invalid irq for vibra\n");
> +		ret = -EINVAL;
> +		goto err_kzalloc;
> +	}

ok, they are platform drivers, so you could be using:

	info->irq = platform_get_irq(pdev, 0);

	if (info->irq < 0) {
		dev_err();
		ret = info->irq;
		goto err_kzalloc;
	}

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)