linux-kernel - Re: [PATCH 2/4] regmap: Add I2C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110709140833.GA17655@opensource.wolfsonmicro.com>
Date:	Sat, 9 Jul 2011 23:08:36 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Greg KH <greg@...ah.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Oritz <sameo@...ux.intel.com>,
	Graeme Gregory <gg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] regmap: Add I2C bus support

On Sat, Jul 09, 2011 at 01:53:07PM +0200, Wolfram Sang wrote:
> On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote:

> > +#include <linux/regmap.h>
> > +#include <linux/i2c.h>
> > +#include <linux/module.h>

> I second Lars-Peter with init.h here (from his first review).

Remind me of what you're talking about here?

> > +	if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING))
> > +		return -ENOTSUPP;

> Even more here. MANGLING is not needed for reading (and it will fail for a
> number of i2c-masters).

Huh, though I'd removed this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/