linux-kernel - Re: [PATCH 2/4] regmap: Add I2C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110709145733.GA1893@pengutronix.de>
Date:	Sat, 9 Jul 2011 16:57:33 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Greg KH <greg@...ah.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Oritz <sameo@...ux.intel.com>,
	Graeme Gregory <gg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] regmap: Add I2C bus support

On Sat, Jul 09, 2011 at 11:08:36PM +0900, Mark Brown wrote:
> On Sat, Jul 09, 2011 at 01:53:07PM +0200, Wolfram Sang wrote:
> > On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote:
> 
> > > +#include <linux/regmap.h>
> > > +#include <linux/i2c.h>
> > > +#include <linux/module.h>
> 
> > I second Lars-Peter with init.h here (from his first review).
> 
> Remind me of what you're talking about here?

He suggested including init.h, because of the use of postcore_initcall.

That's minor, of course. But you probably need to resend anyway, because
of the mangling-check in the read function.

But in general: great series! I also had played with the idea of
abstracting I2C/SPI-access away. Will surely try to convert a driver
myself.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)