linux-kernel - Re: [PATCH] drivers/tty/serial/crisv10: fix double assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107110139070.2818@swampdragon.chaosbits.net>
Date:	Mon, 11 Jul 2011 01:39:53 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Edwin van Vliet <edwin@...atah.nl>
cc:	starvik@...s.com, jesper.nilsson@...s.com, alan@...ux.intel.com,
	linux-cris-kernel@...s.com, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/tty/serial/crisv10: fix double assignment

On Mon, 11 Jul 2011, Edwin van Vliet wrote:

> Struct member dma_in_enabled was assigned twice in a row.
> 
> Signed-off-by: Edwin van Vliet <edwin@...atah.nl>
> ---
>  drivers/tty/serial/crisv10.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
> index 225123b..0c55181 100644
> --- a/drivers/tty/serial/crisv10.c
> +++ b/drivers/tty/serial/crisv10.c
> @@ -330,7 +330,6 @@ static struct e100_serial rs_table[] = {
>  	  .dma_in_irq_description = "serial 1 dma rec",
>  #else
>  	  .dma_in_enabled = 0,
> -	  .dma_in_enabled = 0,
>  	  .dma_in_nbr = UINT_MAX,
>  	  .dma_in_irq_nbr = 0,
>  	  .dma_in_irq_flags = 0,
> 
Looks correct to me.
Reviewed-by: Jesper Juhl <jj@...osbits.net>

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/