linux-kernel - Re: [PATCH] Remove incorrect usage of sysctl_vfs_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1310380511.2766.3.camel@menhir>
Date:	Mon, 11 Jul 2011 11:35:11 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	raghu.prabhu13@...il.com, akpm@...ux-foundation.org,
	mgorman@...e.de, kamezawa.hiroyu@...fujitsu.com, keithp@...thp.com,
	viro@...iv.linux.org.uk, riel@...hat.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, jack@...e.cz,
	Raghavendra D Prabhu <rprabhu@...hang.net>
Subject: Re: [PATCH] Remove incorrect usage of sysctl_vfs_cache_pressure

Hi,

On Mon, 2011-07-11 at 12:00 +1000, Dave Chinner wrote:
> On Mon, Jul 11, 2011 at 02:56:23AM +0530, raghu.prabhu13@...il.com wrote:
> > From: Raghavendra D Prabhu <rprabhu@...hang.net>
> > 
> > In shrinker functions, sysctl_vfs_cache_pressure variable is being used while
> > trimming slab caches in general and not restricted to inode/dentry caches as
> > documented for that sysctl.
> > 
> > Raghavendra D Prabhu (1):
> >   mm/vmscan: Remove sysctl_vfs_cache_pressure from non-vfs shrinkers
> > 
> >  drivers/gpu/drm/i915/i915_gem.c |    2 +-
> 
> That's the only questionable use of it as it has nothing to do with
> filesystems.
> 
> >  fs/gfs2/glock.c                 |    2 +-
> >  fs/gfs2/quota.c                 |    2 +-
> >  fs/mbcache.c                    |    2 +-
> >  fs/nfs/dir.c                    |    2 +-
> >  fs/quota/dquot.c                |    3 +--
> >  net/sunrpc/auth.c               |    2 +-
> 
> All the others are filesystem₋specific caches and as such the use of
> vfs_cache_pressure to adjust the balance of reclaim is valid usage.
> Especially the VFS quota cache shrinkers. ;)
> 
> Cheers,
> 
> Dave.

I agree for the two GFS2 uses of this variable. There is no need to make
this change,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/