linux-kernel - Re: [PATCH 1/2] x86-64: Simplify cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMzpN2gK2UTdZzGMr1GYD-qQ0r9cKdGUx7kHG2Z5p5iRJdY7dA@mail.gmail.com>
Date:	Mon, 11 Jul 2011 07:50:43 -0400
From:	Brian Gerst <brgerst@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86-64: Simplify cpu_has_invlpg

On Sun, Jul 10, 2011 at 2:18 PM, H. Peter Anvin <hpa@...or.com> wrote:
> On 07/10/2011 06:53 AM, Brian Gerst wrote:
>> Define CONFIG_X86_INVLPG for 64-bit too, which simplifies the code.
>>
>> Signed-off-by: Brian Gerst <brgerst@...il.com>
>
> I think a much better way to do this kind of stuff is to define
> Linux-specific CPU feature bits (which we already have quite a few of).
>  That way they fall into the same mechanism as everything else that has
> switches on CPU features, we can use alternatives, and so on.

I don't think it's worth getting too fancy with this.  Even if you
used alternatives, you'd want the config option to eliminate the
alternative when compiling for 486+.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/