| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110711082536.GA29007@gallifrey> Date: Mon, 11 Jul 2011 09:25:36 +0100 From: "Dr. David Alan Gilbert" <linux@...blig.org> To: Jesper Juhl <jj@...osbits.net> Cc: teigland@...hat.com, linux-kernel@...r.kernel.org Subject: Re: kmallocs with swapped parameters in fs/dlm/lock.c * Jesper Juhl (jj@...osbits.net) wrote: > On Sun, 10 Jul 2011, Dr. David Alan Gilbert wrote: > > > Hi David, > > Sparse spotted a couple of places in fs/dlm/lock.c where the size/flags > > parameters to kmalloc got swapped: > > > [...] > > Jesper: > > I noticed in your patch: > > https://lkml.org/lkml/2011/7/2/90 > > > > where you had done a kmalloc->kzalloc transform you kept the swap. > > > > This looks like new code in 3.0rc so I don't think you could quite > > call it a regression, but it should probably be fixed fairly quickly > > I guess. > > > D'oh, I completely overlooked that. No problem. > Thank you for noticing and letting me know. I've just submitted an updated > patch. Great - it's probably worth you fixing the 2nd case in the same file in the same patch, rather than just the one that you were changing anyway? Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ gro.gilbert @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists