linux-kernel - Re: [PATCH] modpost: Fix modpost's license checking V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACqU3MVZ6UPZKSsSSjZosTYfbzuwj_dCumK-wcb_SWhs+8OgNQ@mail.gmail.com>
Date:	Tue, 12 Jul 2011 14:15:39 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Anders Kaseorg <andersk@...lice.com>
Cc:	Alessio Igor Bogani <abogani@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jan Beulich <jbeulich@...ell.com>,
	Kbuild <linux-kbuild@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Tim Bird <tim.bird@...sony.com>
Subject: Re: [PATCH] modpost: Fix modpost's license checking V2

Hi,

On Tue, Jul 12, 2011 at 2:02 PM, Anders Kaseorg <andersk@...lice.com> wrote:
> On Tue, Jul 12, 2011 at 03:00, Alessio Igor Bogani <abogani@...nel.org> wrote:
>> +#define SEC_NAME_MATCH(name, str) (strncmp(name, str, strlen(str) - 1) == 0)
>
> Surely you meant strlen() or sizeof() - 1, not strlen() - 1?
>
>> +       if (!is_vmlinux(mod->name) && strncmp(symname, "__ksymtab", 9) == 0)
>
> Same strncmp pattern here.  BTW, your macro is the strstarts()
> function in include/linux/string.h.
>
modpost is an host tool, it should not include kernel header. Content
of this file is not exported to userland anyway.

 - Arnaud

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/