linux-kernel - Re: [PATCH] signals: sys_ssetmask/sys_rt_sigsuspend should use set_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110712191730.3fb554a4@mfleming-mobl1.ger.corp.intel.com>
Date:	Tue, 12 Jul 2011 19:17:30 +0100
From:	Matt Fleming <matt.fleming@...ux.intel.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signals: sys_ssetmask/sys_rt_sigsuspend should use
 set_current_blocked()

On Mon, 11 Jul 2011 18:01:02 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> sys_ssetmask(), sys_rt_sigsuspend() and compat_sys_rt_sigsuspend()
> change ->blocked directly. This is not correct, see the changelog in
> e6fa16ab "signal: sigprocmask() should do retarget_shared_pending()"
> 
> Change them to use set_current_blocked().
> 
> Another change is that now we are doing ->saved_sigmask = ->blocked
> lockless, it doesn't make any sense to do this under ->siglock.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Reviewed-by: Matt Fleming <matt.fleming@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/