linux-kernel - Re: [PATCH 1/8] bootmem: Replace work_with_active_regions() with for_each_mem_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E1E5058.5020702@zytor.com>
Date:	Wed, 13 Jul 2011 19:11:36 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Tejun Heo <tj@...nel.org>
CC:	mingo@...hat.com, tglx@...utronix.de, benh@...nel.crashing.org,
	yinghai@...nel.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH 1/8] bootmem: Replace work_with_active_regions() with
 for_each_mem_pfn_range()

On 07/12/2011 01:46 AM, Tejun Heo wrote:
> Callback based iteration is cumbersome and much less useful than
> for_each_*() iterator.  This patch implements for_each_mem_pfn_range()
> which replaces work_with_active_regions().  All the current users of
> work_with_active_regions() are converted.
> 
> This simplifies walking over early_node_map and will allow converting
> internal logics in page_alloc to use iterator instead of walking
> early_node_map directly, which in turn will enable moving node
> information to memblock.
> 
> powerpc change is only compile tested.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Yinghai Lu <yinghai@...nel.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>

This patch causes a build failure on x86-64 with the attached .config:

/home/hpa/kernel/linux-2.6-tip.memblock/drivers/pci/intel-iommu.c: In
function ‘si_domain_init’:
/home/hpa/kernel/linux-2.6-tip.memblock/drivers/pci/intel-iommu.c:2216:4: error:
implicit declaration of function ‘iommuc_domain_identity_map’
[-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

	-hpa

View attachment ".config" of type "text/plain" (76915 bytes)