linux-kernel - Re: RFC: Boiler plate functions for ida / idr allocation?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E208302.9020908@panasas.com>
Date:	Fri, 15 Jul 2011 11:12:18 -0700
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Benny Halevy <bhalevy@...asas.com>, <osd-dev@...n-osd.org>,
	Jonathan Cameron <jic23@....ac.uk>,
	LKML <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: RFC: Boiler plate functions for ida / idr allocation?

On 07/13/2011 05:41 AM, Stefan Richter wrote:
> On Jul 13 Jonathan Cameron wrote at LKML:
> [...]
>> Taking ida's first, how about the following patch?  I'm not at
>> all attached to the form it takes, merely to cutting out on the
>> cut and paste.
>>
>> Note I've done only a few random places.  There aren't that many ida
>> users and I've only played with that for now.
>>
>> Remaining ida cases:
>>
>> drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c:  (cleans up in case of out of range)
>> drivers/scsi/osd/osd_uld.c: (locks not taken)
> [...]
> 
> Boaz, Benny,
> 
> osd_uld.c::osd_minor_ida is accessed unsafely.
> Device probe() and remove() methods are not globally serialized.

Sorry for the delay. Vacation

Thanks Stefan I'll look into it. I remember I thought about
it and tested it at the time, but I might be wrong. I'll look
into it.

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/