linux-kernel - Re: RFC: Boiler plate functions for ida / idr allocation?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2011 23:35:22 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Benny Halevy <bhalevy@...asas.com>, <osd-dev@...n-osd.org>,
	Jonathan Cameron <jic23@....ac.uk>,
	LKML <linux-kernel@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: RFC: Boiler plate functions for ida / idr allocation?

On Jul 15 Boaz Harrosh wrote:
> On 07/13/2011 05:41 AM, Stefan Richter wrote:
> > osd_uld.c::osd_minor_ida is accessed unsafely.
> > Device probe() and remove() methods are not globally serialized.
> 
> Sorry for the delay. Vacation
> 
> Thanks Stefan I'll look into it. I remember I thought about
> it and tested it at the time, but I might be wrong. I'll look
> into it.

Could actually be that there was or even still is some degree of
serialization by the SCSI core in typical usage.  But I think the
general case is nowadays fully concurrent.  E.g.
    echo $name > /sys/bus/scsi/drivers/osd*/{,un}bind
if issued in parallel for different device names.  Though it is probably
borderline impossible to actually hit a concurrent osd_minor_ida access on
purpose.
-- 
Stefan Richter
-=====-==-== -=== -====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/