linux-kernel - RE: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B3F95056718EDE47B73D925D2FF34506782CB0@EX1.faraday.com.tw>
Date:	Mon, 18 Jul 2011 20:54:32 +0800
From:	Wendy Yuan-Hsin Chen(陳元馨) 
	<yhchen@...aday-tech.com>
To:	<balbi@...com>
Cc:	"Sebastian Andrzej Siewior" <bigeasy@...utronix.de>,
	"Greg Kroah-Hartman" <gregkh@...e.de>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, "Joe Perches" <joe@...ches.com>
Subject: RE: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

Hi,

> >>>diff --git a/drivers/usb/gadget/fusb300_udc.c
> >>>b/drivers/usb/gadget/fusb300_udc.c
> >>>index 06353e7..453bc0f 100644
> >>>--- a/drivers/usb/gadget/fusb300_udc.c
> >>>+++ b/drivers/usb/gadget/fusb300_udc.c
> >>>@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
> >>> 	switch (length % 4) {
> >>> 	case 1:
> >>> 		golden_value = *tmp;
> >>>+		break;
> >>> 	case 2:
> >>> 		golden_value = *tmp | *(tmp + 1) << 8;
> >>>+		break;
> >>> 	case 3:
> >>> 		golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
> >>>+		break;
> >>> 	default:
> >>> 		break;
> >>> 
> >
> >>That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?
> >
> >It's ok to remove the #if 0. But the warning will occur while compling.
> 
> By removing the #if 0 block I meant to remove the unused functions
> fusb300_cmp_dbg_fifo() and fusb300_dbg_fifo(). There should be no warning then.
> Are you okey with this? Are those function required?
> 
> These funtions are used for debugging. I think it's ok to remove them. Thanks.

maybe make a debugfs interface instead ?

These functions were used to debug unstable hw fifo while developing fusb300.  It's much more stable now.
So these functions can be removed. Thanks for your advice.

Yuan-Hsin

********************* Confidentiality Notice ************************
This electronic message and any attachments may contain
confidential and legally privileged information or
information which is otherwise protected from disclosure.
If you are not the intended recipient,please do not disclose
the contents, either in whole or in part, to anyone,and
immediately delete the message and any attachments from
your computer system and destroy all hard copies.
Thank you for your cooperation.
***********************************************************************

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/