linux-kernel - Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110718083640.GB2837@legolas.emea.dhcp.ti.com>
Date:	Mon, 18 Jul 2011 11:36:42 +0300
From:	Felipe Balbi <balbi@...com>
To:	Wendy Yuan-Hsin Chen(陳元馨) 
	<yhchen@...aday-tech.com>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

Hi,

On Thu, Jul 14, 2011 at 09:28:46PM +0800, Wendy Yuan-Hsin Chen(陳元馨) wrote:
> >>>diff --git a/drivers/usb/gadget/fusb300_udc.c
> >>>b/drivers/usb/gadget/fusb300_udc.c
> >>>index 06353e7..453bc0f 100644
> >>>--- a/drivers/usb/gadget/fusb300_udc.c
> >>>+++ b/drivers/usb/gadget/fusb300_udc.c
> >>>@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
> >>> 	switch (length % 4) {
> >>> 	case 1:
> >>> 		golden_value = *tmp;
> >>>+		break;
> >>> 	case 2:
> >>> 		golden_value = *tmp | *(tmp + 1) << 8;
> >>>+		break;
> >>> 	case 3:
> >>> 		golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
> >>>+		break;
> >>> 	default:
> >>> 		break;
> >>> 
> >
> >>That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?
> >
> >It's ok to remove the #if 0. But the warning will occur while compling.
> 
> By removing the #if 0 block I meant to remove the unused functions
> fusb300_cmp_dbg_fifo() and fusb300_dbg_fifo(). There should be no warning then.
> Are you okey with this? Are those function required?
> 
> These funtions are used for debugging. I think it's ok to remove them. Thanks.

maybe make a debugfs interface instead ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)