[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110718.124638.30010338187296272.davem@davemloft.net>
Date: Mon, 18 Jul 2011 12:46:38 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: rweikusat@...ileactivedefense.com
Cc: adobriyan@...il.com, kaber@...sh.net,
netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c
From: Rainer Weikusat <rweikusat@...ileactivedefense.com>
Date: Mon, 18 Jul 2011 20:43:30 +0100
> [rw@...phire]~/work/linux-2-6/net/netfilter $find -name '*.c' | xargs grep '^#ifdef' | wc -l
> 239
> [rw@...phire]~/work/linux-2-6/net/netfilter $..
> [rw@...phire]~/work/linux-2-6/net $find -name '*.c' | xargs grep '^#ifdef' | wc -l
> 1672
You've shown nothing. Showing exceptions does not prove that the
general effort has been to keep ifdef crap out of *.c files.
And every developer or maintainer who says no to ifdefs in *.c files
for new changes is %100 right.
We're also specifically talking about namespace stuff, so you should have
at least refined your match criteria just a little bit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists