linux-kernel - Re: [tip:x86/vdso] x86-64: Allow alternative patching in the vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 15:54:21 -0400
From:	Andrew Lutomirski <luto@....edu>
To:	Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@....edu>,
	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de,
	hpa@...ux.intel.com
Subject: Re: [tip:x86/vdso] x86-64: Allow alternative patching in the vDSO

On Mon, Jul 18, 2011 at 3:10 PM, Borislav Petkov <bp@...en8.de> wrote:
> On Fri, Jul 15, 2011 at 04:23:18AM +0000, tip-bot for Andy Lutomirski wrote:
>> Commit-ID:  1b3f2a72bbcfdf92e368a44448c45eb639b05b5e
>> Gitweb:     http://git.kernel.org/tip/1b3f2a72bbcfdf92e368a44448c45eb639b05b5e
>> Author:     Andy Lutomirski <luto@....edu>
>> AuthorDate: Wed, 13 Jul 2011 09:24:11 -0400
>> Committer:  H. Peter Anvin <hpa@...ux.intel.com>
>> CommitDate: Wed, 13 Jul 2011 11:23:07 -0700
>>
>> x86-64: Allow alternative patching in the vDSO
>>
>> This code is short enough and different enough from the module
>> loader that it's not worth trying to share anything.
>>
>> Signed-off-by: Andy Lutomirski <luto@....edu>
>> Link: http://lkml.kernel.org/r/e73112e4381fff29e31b882c2d0856822edaea53.1310563276.git.luto@mit.edu
>> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
>
> --
> From: Borislav Petkov <bp@...en8.de>
> Date: Mon, 18 Jul 2011 21:07:25 +0200
> Subject: [PATCH] x86, vdso: Drop now wrong comment
>
> Now that 1b3f2a72bbcfdf92e368a44448c45eb639b05b5e is in, it is very
> important that the below lying comment be removed! :-)
>
> Signed-off-by: Borislav Petkov <bp@...en8.de>
> ---
>  arch/x86/vdso/vclock_gettime.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/vdso/vclock_gettime.c b/arch/x86/vdso/vclock_gettime.c
> index 8792d6e..6bc0e72 100644
> --- a/arch/x86/vdso/vclock_gettime.c
> +++ b/arch/x86/vdso/vclock_gettime.c
> @@ -6,7 +6,6 @@
>  *
>  * The code should have no internal unresolved relocations.
>  * Check with readelf after changing.
> - * Also alternative() doesn't work.
>  */

That was the whole point, after all.

Acked-by: Andy Lutomirski <luto@....edu>

>
>  /* Disable profiling for userspace code: */
> --
> 1.7.5.3.401.gfb674
>
> --
> Regards/Gruss,
>    Boris.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/