lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 19 Jul 2011 22:46:15 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Joe Perches <joe@...ches.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and
 warnings



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Tuesday, July 19, 2011 3:29 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and
> warnings
> 
> On Tue, 2011-07-19 at 11:44 -0700, K. Y. Srinivasan wrote:
> > Fix checkpatch errors and warnings.
> []
> > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
> []
> > @@ -53,7 +53,7 @@ struct hv_input_dev_info {
> > -#pragma pack(push,1)
> > +#pragma pack(push, 1)
> >  /*
> >   * Message types in the synthetic input protocol
> >   */
> 
> Perhaps it's better and more consistent with
> other kernel style uses to remove #pragma pack[...]
> and mark the individual structs with __packed;

Good point. Currently, this driver is not functional. When the driver
is finally functional, there is a whole lot of cleanup that is needed and I will
do what you are suggesting then. For this go around, I just wanted to address
checkpatch issues with minimal change.

Regards,

K. Y 

Powered by blists - more mailing lists