| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110720194603.GA3385@albatros> Date: Wed, 20 Jul 2011 23:46:03 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <bsingharora@...il.com>, Jerome Marchand <jmarchan@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's On Wed, Jul 20, 2011 at 21:00 +0200, Oleg Nesterov wrote: > When send_cpu_listeners() finds the orphaned listener it marks > it as !valid and drops listeners->sem. Before it takes this sem > for wrinting, s->pid can be reused and add_del_listener() can > wrongly try to re-use this entry. > > Change add_del_listener() to check ->valid = T. I think the current logic is wrong. If s was claimed is invalid, it then points to a dead task, it is unknown when it died. As the same pid can be reused by a new process BEFORE add_del_listener(), it is unknown whether ->pid points to the actual owner task. Rather than optimizing the wrong algorithm it's better to change the processes keeping way. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists