linux-kernel - Re: [PATCH 01/11] MFD: DA9052 MFD core module v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11313494.PB6mQOoBLX@wuerfel>
Date:	Thu, 21 Jul 2011 22:40:23 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Shawn Guo <shawn.guo@...escale.com>,
	ashishj3 <ashish.jangam@...tcummins.com>,
	Dajun <dajun.chen@...semi.com>, sameo@...nedhand.com,
	linaro-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v2

On Thursday 21 July 2011 16:47:48 Mark Brown wrote:
> On Thu, Jul 21, 2011 at 11:46:32PM +0800, Shawn Guo wrote:
> > On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:
> 
> > > +   mutex_lock_interruptible(&da9052->io_lock);
> 
> > Compile warning as below.
> 
> > "warning: ignoring return value of ‘mutex_lock_interruptible’,
> > declared with attribute warn_unused_result"
> 
> Although the bigger problem is why are these interruptible?  That's
> very unusual.

Well, the default should really be to use _interruptible or at least
_killable with the appropriate error handling, and only use noninterruptible
locks  in cases where that's not possible.

In the funtions that Shawn pointed out, there is an error return, so it would
be possible to do that, but the callers would need to be audited carefully.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/