linux-kernel - Re: [Patch] VFS : mount lock scalability for files systems without mount point (WAS vfsmount lock issues on very large ppc64 box)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110721204042.GB31405@ZenIV.linux.org.uk>
Date:	Thu, 21 Jul 2011 21:40:42 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tim Chen <tim.c.chen@...ux.intel.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Matthew Wilcox <matthew@....cx>,
	Anton Blanchard <anton@...ba.org>, npiggin@...nel.dk,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [Patch] VFS : mount lock scalability for files systems without
 mount point   (WAS vfsmount lock issues on very large ppc64 box)

On Tue, Jul 19, 2011 at 09:32:38AM -0700, Tim Chen wrote:
> @@ -1193,6 +1193,7 @@ static void __exit cleanup_mtdchar(void)
>  {
>  	unregister_mtd_user(&mtdchar_notifier);
>  	mntput(mtd_inode_mnt);
> +	kern_unmount(mtd_inode_mnt);

Surely you want to merge that mntput() in there...

> +void kern_unmount(struct vfsmount *mnt)
> +{
> +	/* release long term mount so mount point can be released */
> +	if (!IS_ERR_OR_NULL(mnt)) {
> +		mnt_make_shortterm(mnt);
> +		mntput();
> +	}
> +}

... and if you pass it the argument, it'll be much happier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/