linux-kernel - Re: [PATCH 0/11 v3] Generic Watchdog Timer Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110722191847.GI31767@infomag.iguana.be>
Date:	Fri, 22 Jul 2011 21:18:47 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/11 v3] Generic Watchdog Timer Driver

Hi Wolfram,

> > Changes since V2:
> > * all "flags" are unsigned
> > * timeout values are also unsigned
> > * removed unnececessary debugging
> > * clean-up comments
> > * the core will be in drivers/watchdog/ and not in drivers/watchdog/core/
> 
> Also (just in case someone started converting drivers):
> 
> * some error-codes changed
> * .name has been removed from watchdog_device in favor of watchdog_info->identity

Yup, I forgot these. Thanks.

Status update: I incorporated your comments and Lars-Peter Clausen's comments and
created V4.  The changes since V3 are:
* removed overdocumentation
* removed MODULE_SUPPORTED_DEVICE and +MODULE_ALIAS_MISCDEV
* removed return -ENOTTY after switch (cmd) because we have the default allready
* s/sent/send/
* I'd suggest to swap the logic here (branch taken on error)
* no_llseek removal squashed into patch 1
* provide getter/setter methods for driver specific data so that we can easily do the conversion towards the device driver model
* removed parent because this would change when we will start using the device driver model

> I already started converting a few drivers and will post the patches as RFC
> tomorrow. In general, converting went quite well and despite a few comments
> (see later mails), I think this could go into 3.1, so that converted drivers
> can go into 3.2 together with (probably) a few updates to the framework. There
> is potential for a bit more consolidation, yet I think the basic stuff could
> go in now.
> 
> Thanks to Wim and Alan for their work and CELF/LF for supporting the final
> steps :)

And for your assistance and the feedback from others also.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/