linux-kernel - Re: [PATCH 01/11] watchdog: WatchDog Timer Driver Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110722192425.GJ31767@infomag.iguana.be>
Date:	Fri, 22 Jul 2011 21:24:25 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 01/11] watchdog: WatchDog Timer Driver Core - Add basic
	framework

Hi Wolfram,

> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 372bc64..edb0f1b 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -28,6 +28,17 @@ menuconfig WATCHDOG
> >  
> >  if WATCHDOG
> >  
> > +config WATCHDOG_CORE
> > +	tristate "WatchDog Timer Driver Core"
> 
> What about the idea of making this bool and let it always be compiled as soon
> as WATCHDOG is selected?

This should indeed have been bool. For this merge window it will stay as WATCHDOG_CORE.
In a futue release WATCHDOG_CORE will disappear and the watchdog core will be dependant
on CONFIG_WATCHDOG. Goal is that we only have 1 lower-level API and that all other drivers
use that.

> > +int watchdog_register_device(struct watchdog_device *wdd)
> > +{
> > +	int ret;
> > +
> > +	/* Make sure we have a valid watchdog_device structure */
> > +	if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL)
> > +		return -EINVAL;
> > +
> > +	/* Make sure that the mandatory operations are supported */
> > +	if (wdd->ops->start == NULL || wdd->ops->stop == NULL)
> > +		return -EINVAL;
> 
> Check also for wdd->ops->owner? Should we mark it as mandatory?

No, see other comments also (if built-in owner is NULL).

All other comments have been incorporated.
It's allready in the linux-2.6-watchdog-next tree. Will try to sent out the new series as soon as possible.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/