linux-kernel - Re: [PATCH] rtc-tegra: properly initialize spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110722151338.9b1e9594.akpm@linux-foundation.org>
Date:	Fri, 22 Jul 2011 15:13:38 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Andrew Chew <achew@...dia.com>, linux-rt-users@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, jkastner@...hat.com
Subject: Re: [PATCH] rtc-tegra: properly initialize spinlock

On Fri, 22 Jul 2011 10:35:56 +0200
Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de> wrote:

> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and
> breaks with PREEMPT_RT_FULL.

Please define "breaks".  Lockdep warnings?  Deadlocks?

> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
> index 2fc31aa..75259fe 100644
> --- a/drivers/rtc/rtc-tegra.c
> +++ b/drivers/rtc/rtc-tegra.c
> @@ -343,7 +343,7 @@ static int __devinit tegra_rtc_probe(struct platform_device *pdev)
>  
>  	/* set context info. */
>  	info->pdev = pdev;
> -	info->tegra_rtc_lock = __SPIN_LOCK_UNLOCKED(info->tegra_rtc_lock);
> +	spin_lock_init(&info->tegra_rtc_lock);
>  
>  	platform_set_drvdata(pdev, info);
>  
> -- 
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/