linux-kernel - Re: [PATCH] rtc-tegra: properly initialize spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Jul 2011 09:29:08 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sven-Thorsten Dietrich <thebigcorporation@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Andrew Chew <achew@...dia.com>,
	linux-rt-users@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, jkastner@...hat.com
Subject: Re: [PATCH] rtc-tegra: properly initialize spinlock

On Fri, 22 Jul 2011, Sven-Thorsten Dietrich wrote:
> 
> On Jul 22, 2011, at 3:13 PM, Andrew Morton wrote:
> 
> > On Fri, 22 Jul 2011 10:35:56 +0200
> > Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de> wrote:
> > 
> >> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and
> >> breaks with PREEMPT_RT_FULL.
> > 
> > Please define "breaks".  Lockdep warnings?  Deadlocks?
> 
> Narrr, I think its a compile-time problem with the static initializer.

Correct. The macro expansion magic of the static initializer barfs and
with lockdep the lockdep key assignment is missing.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/