linux-kernel - Re: [PATCH] fix fat utf8 iocharset warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107241921350.5758@swampdragon.chaosbits.net>
Date:	Sun, 24 Jul 2011 19:22:44 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Mihai Moldovan <ionic@...ic.de>
cc:	LKML <linux-kernel@...r.kernel.org>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Subject: Re: [PATCH] fix fat utf8 iocharset warning message

On Sun, 24 Jul 2011, Mihai Moldovan wrote:

> The fat_msg function already formats the given message and appends
> a newline to it - we don't need to do this in the passed message
> string as well, or will end up with a blank line printed in the
> kernel log ring buffer.
> 
> Signed-off-by: Mihai Moldovan <ionic@...ic.de>
> Cc: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> ---
>  fs/fat/inode.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 5942fec..46530a1 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1190,7 +1190,7 @@ out:
>      if (!strcmp(opts->iocharset, "utf8")) {
>          fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"

Is KERN_ERR really the right thing to use here? 
Sounds more like a warning to me..


>                 " for FAT filesystems, filesystem will be "
> -               "case sensitive!\n");
> +               "case sensitive!");
>      }
>  
>      /* If user doesn't specify allow_utime, it's initialized from dmask. */
> 

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/