linux-kernel - Re: GMA500: ERROR: "__bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110725224250.7d6edb83@bob.linux.org.uk>
Date:	Mon, 25 Jul 2011 22:42:50 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ryan Mallon <rmallon@...il.com>, Jesper Juhl <jj@...osbits.net>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	devel@...verdev.osuosl.org
Subject: Re: GMA500: ERROR: "__bad_udelay" undefined!

On Mon, 25 Jul 2011 23:08:42 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> On Monday 25 July 2011 11:28:44 Ryan Mallon wrote:
> > 
> > diff --git a/drivers/staging/gma500/psb_intel_display.c
> > b/drivers/staging/gma500/psb_intel_display.c index 4f47d09..09e378d
> > 100644 --- a/drivers/staging/gma500/psb_intel_display.c
> > +++ b/drivers/staging/gma500/psb_intel_display.c
> > @@ -331,7 +331,7 @@ static bool psb_intel_find_best_PLL(struct
> > drm_crtc *crtc, int target, void psb_intel_wait_for_vblank(struct
> > drm_device *dev) {
> >         /* Wait for 20ms, i.e. one cycle at 50hz. */
> > -       udelay(20000);
> > +       mdelay(20);
> >   }
> > 
> >   int psb_intel_pipe_set_base(struct drm_crtc *crtc,
> 
> A 20 ms busy wait is rather nasty. Can't this be replaced with a
> sleeping wait (msleep)?

Don't know yet - its on the fixme list to dig into - I think the answer
is some cases but not all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/