linux-kernel - Re: GMA500: ERROR: "__bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMeQTsY3T5sPCRYzf8-Xca8y_mWjXSUOOptxHZ2YK5YNL0uvuw@mail.gmail.com>
Date:	Tue, 26 Jul 2011 11:06:17 +0200
From:	Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Ryan Mallon <rmallon@...il.com>,
	Jesper Juhl <jj@...osbits.net>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org
Subject: Re: GMA500: ERROR: "__bad_udelay" undefined!

>> A 20 ms busy wait is rather nasty. Can't this be replaced with a
>> sleeping wait (msleep)?
>
> Don't know yet - its on the fixme list to dig into - I think the answer
> is some cases but not all.

IMO, it should be replaced with actually waiting for the vblank and not an
arbitrary time. I think this is fine as long as we don't use it when waiting for
a pipe to disable. And I guess we could sleep while waiting for vblank.

Patrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/