linux-kernel - Re: [GIT PULL] iscsi-target merge for v3.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1311666670.17766.241.camel@haakon2.linux-iscsi.org>
Date:	Tue, 26 Jul 2011 00:51:10 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	target-devel <target-devel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Andy Grover <agrover@...hat.com>,
	Hannes Reinecke <hare@...e.de>,
	Roland Dreier <roland@...estorage.com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Boaz Harrosh <openosd@...il.com>,
	Mike Christie <michaelc@...wisc.edu>
Subject: Re: [GIT PULL] iscsi-target merge for v3.1-rc1

On Tue, 2011-07-26 at 00:43 -0700, Andrew Morton wrote:
> On Tue, 26 Jul 2011 00:09:40 -0700 Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > Just a simple
> > 
> > #define DIV_ROUND_UP_ULL(ll,d) \
> >   ({ unsigned long long _tmp = (ll)+(d)-1; do_div(_tmp, d); _tmp; })
> > 
> > looks like it would work and be simpler. Avoid the conditional, do the
> > same "add 'd-1' thing as the regular ROUND_UP().
> > 
> 
> We might end up needing a DIV_ROUND_UP_SECTOR_T because that guy's
> type/size is Kconfigurable.
> 
> otoh DIV_ROUND_UP_ULL won't have many callsites - the occasional
> conversion from UL to ULL then back to UL wouldn't kill us.  Unless
> there be subtle problems with such a conversion.
> 

Makes sense to me, and sending out updated series..  Anything else to
consider here folks before pushing into target-pending.git/for-next..?

Thanks!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/