lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jul 2011 08:34:53 -0400 From: Christoph Hellwig <hch@...radead.org> To: David Wagner <david.wagner@...e-electrons.com> Cc: linux-mtd@...ts.infradead.org, dedekind1@...il.com, dwmw2@...radead.org, linux-kernel@...r.kernel.org, linux-embedded@...r.kernel.org, tim.bird@...sony.com Subject: Re: [PATCH] UBI: new module ubiblk: block layer on top of UBI > TODO: > * the modules keeps a table of the devices which length is the maximum number > of UBI volumes. It should make use of a linked list. A linked list isn't very nice either. Try using idr, which gives you both an allocator for the minor number space, and a way to look up the structure by that index. > Advantages of ubiblk over gluebi+mtdblock_ro: This section should be in the main commit log, and not that part with the changelog which gets dropped. > +int major; Please don't use global variables with generic names. In this case you should neither make it global nor give it a generic name. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists