linux-kernel - Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YOYOMNmLTn=MLdObwfUPLb-xOr1Xw7aLoEWcDb8esAX4A@mail.gmail.com>
Date:	Tue, 26 Jul 2011 23:46:11 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	benh@...nel.crashing.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free_range()
 with generic ones

Hello, Yinghai.

On Tue, Jul 26, 2011 at 11:06 PM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> Wonder if we have a new function like
>
> __memblock_reserve(addr, size, name)
>
> in mm/memblock.c
>
> so could keep string for debug purpose instead of using _RET_IP_.
>
> with that, we can figure out what is in exact reserved position with boot log.

If you look at the current users, the caller function name is unique
except for one or two cases, so we can already tell who's doing what
even without consulting the exact IP.  I can't see much point in
providing debug strings explicitly.  The only benefit would be that it
would be prettier but these are purely debug messages.  One thing
which might make sense is preserving _RET_IP_ of callers of alloc
functions so that reserve can show who's allocating instead of
printing the alloc function each time.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/