linux-kernel - Re: [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1311658034.26957.3.camel@Joe-Laptop>
Date:	Mon, 25 Jul 2011 22:27:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 1/1] Staging: comedi: fix printk issue in c6xdigio.c

On Tue, 2011-07-26 at 10:57 +0530, Ravishankar wrote:
> This is a patch to the c6xdigio.c file that fixes up a printk warning found by the checkpatch.pl tool
> diff --git a/drivers/staging/comedi/drivers/c6xdigio.c b/drivers/staging/comedi/drivers/c6xdigio.c
[]
> @@ -343,7 +343,7 @@ static int c6xdigio_pwmo_insn_read(struct comedi_device *dev,
[]
> -	printk("c6xdigio_pwmo_insn_read %x\n", insn->n);
> +	pr_info("c6xdigio_pwmo_insn_read %x\n", insn->n);

It would be good if you would convert embedded function names
to "%s", __func__.  Maybe convert the bare printks to appropriate
levels as well.  Perhaps:

	pr_debug("%s: %x\n", __func__, insn->n);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/