linux-kernel - Re: block: BUG: using smp_processor_id() in preemptible [00000000] code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPK9B65-McHv9HVsmLNZdwfeLbVgYYagpK-ymEK+hC0RQ@mail.gmail.com>
Date:	Tue, 26 Jul 2011 14:22:43 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: block: BUG: using smp_processor_id() in preemptible [00000000] code

Hi,

On Tue, Jul 26, 2011 at 1:26 PM, Jens Axboe <jaxboe@...ionio.com> wrote:
> On 2011-07-26 06:49, Ming Lei wrote:
>> Hi,
>>
>> The bug is observed in -next-20110725, follows the stack trace[1], and
>> seems the attachment patch can fix the bug.
>
> Does this work, too? We don't necessarily need the CPU stable, but
> spewing debug output isn't very nice.

This does work, thanks,

> diff --git a/block/blk-core.c b/block/blk-core.c
> index f8cb099..f925581 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1283,7 +1283,7 @@ get_rq:
>
>        if (test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags) ||
>            bio_flagged(bio, BIO_CPU_AFFINE))
> -               req->cpu = smp_processor_id();
> +               req->cpu = raw_smp_processor_id();
>
>        plug = current->plug;
>        if (plug) {
>
> --
> Jens Axboe
>
>


thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/