linux-kernel - [RFC patch] DMAengine/Langwell: put dev object in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJd=RBCO=Hhb4oCsmXgQ+HHRL6CWCDe6yRvo7wg+qXOcr6UsAg@mail.gmail.com>
Date:	Wed, 27 Jul 2011 21:24:32 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: [RFC patch] DMAengine/Langwell: put dev object in error path

When allocating resources for DMA channel, if error encountered, the dev object
of the relevant DMA device should be put, corresponding to the get operation.

Signed-off-by: Hillf Danton <dhillf@...il.com>
---
 drivers/dma/intel_mid_dma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
index f653517..85bd8f3 100644
--- a/drivers/dma/intel_mid_dma.c
+++ b/drivers/dma/intel_mid_dma.c
@@ -871,6 +871,7 @@ static int
intel_mid_dma_alloc_chan_resources(struct dma_chan *chan)
 	if (mid->state == SUSPENDED) {
 		if (dma_resume(mid->pdev)) {
 			pr_err("ERR_MDMA: resume failed");
+			pm_runtime_put(&mid->pdev->dev);
 			return -EFAULT;
 		}
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/