linux-kernel - Re: [RFC patch] DMAengine/Langwell: put dev object in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312824109.1539.39.camel@vkoul-udesk3>
Date:	Mon, 08 Aug 2011 22:51:49 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC patch] DMAengine/Langwell: put dev object in error path

On Wed, 2011-07-27 at 21:24 +0800, Hillf Danton wrote:
> When allocating resources for DMA channel, if error encountered, the dev object
> of the relevant DMA device should be put, corresponding to the get operation.
> 
> Signed-off-by: Hillf Danton <dhillf@...il.com>
> ---
>  drivers/dma/intel_mid_dma.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c
> index f653517..85bd8f3 100644
> --- a/drivers/dma/intel_mid_dma.c
> +++ b/drivers/dma/intel_mid_dma.c
> @@ -871,6 +871,7 @@ static int
> intel_mid_dma_alloc_chan_resources(struct dma_chan *chan)
This again looks corrupt

>  	if (mid->state == SUSPENDED) {
>  		if (dma_resume(mid->pdev)) {
>  			pr_err("ERR_MDMA: resume failed");
> +			pm_runtime_put(&mid->pdev->dev);
>  			return -EFAULT;
>  		}
>  	}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/