linux-kernel - Re: [PULL REQUEST] ext3, jbd, ext2, and quota fixes for 3.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110727003108.GA19851@thunk.org>
Date:	Tue, 26 Jul 2011 20:31:08 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
	Josef Bacik <josef@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PULL REQUEST] ext3, jbd, ext2, and quota fixes for 3.1-rc1

On Tue, Jul 26, 2011 at 12:14:28PM -0700, Linus Torvalds wrote:
> On Tue, Jul 26, 2011 at 11:59 AM, Christoph Hellwig <hch@...radead.org> wrote:
> >
> > In addition to beeing bogus the code also is useless.  fsync on a file
> > explicitly does not guarantee anything at all about the parent, and
> > never really has on Linux either.
> 
> Well, it may never have done that, but it might still be a case of
> quality-of-implementation.
> 
> The data blocks and inode indirect blocks being stable on disk doesn't
> help hugely if you cannnot actually reach the inode itself.

Yeah, that's why it was done.  Frank found that with power-fail
testing, a large number of files that were freshly created and then
fsync()'ed would disappear.  If the data is supposed to be available
after a power failure, then you have to be able to get to it somehow.

I agree what's there isn't safe, and needs to be fixed.  I'll deal
with it.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/