linux-kernel - Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1311855169.2617.168.camel@laptop>
Date:	Thu, 28 Jul 2011 14:12:49 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH v2 0/6] Add tracepoints to trace all system IRQs

On Wed, 2011-07-27 at 11:57 -0700, Vaibhav Nagarnaik wrote:
> This is a patch series aiming to trace all the system IRQs. The
> tracepoints make it easier to understand IRQ interaction with other
> system events and find out how much time is spent in kernel space versus
> user space.

That doesn't cover the actual rational, you can get that information by
using CONFIG_IRQ_TIME_ACCOUNTING.

> Patches 1-5 add tracepoints to the generic kernel IRQ handlers to
> benefit all the architectures, as suggested by Frederic. Patch#6 adds
> trace events to trace all platform specific interrupt vectors which do
> not have any generic handlers. This patch traces x86 IRQ vectors but can
> be used by other architectures to trace their vectors too.
> 
> Changelog v2-v1:
> * Fix patch#3 to trace IRQ work run vector even when the irq work list
>   is empty
> * Fix patch#5 to use updated trace event names,
>   call_function_ipi_(entry|exit) and
>   call_function_single_ipi_(entry|exit)
> * Rebase to 3.0
> * Update changelog

I still completely hate how you make new events for every interrupt
source. That's a massive pollution of the event space.

Also, since you do arch specific things anyway, why not from a single
tracepoint into the arch interrupt stubs and be done with it, no need to
puke all over the rest of the code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/