linux-kernel - Re: [PATCH] [9/50] mmc: Added quirks for Ricoh 1180:e823 lower base clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2r559di9y.fsf@bob.laptop.org>
Date:	Thu, 28 Jul 2011 20:47:53 -0400
From:	Chris Ball <cjb@...top.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	matsumur@....ricoh.co.jp, ak@...ux.intel.com,
	daniel.manrique@...onical.com, jbarnes@...tuousgeek.org,
	linux-kernel@...r.kernel.org, manoj.iyer@...onical.com,
	stable@...nel.org, tim.bird@...sony.com
Subject: Re: [PATCH] [9/50] mmc: Added quirks for Ricoh 1180:e823 lower base clock

Hi,

On Thu, Jul 28 2011, Andi Kleen wrote:
> On Fri, Jul 29, 2011 at 09:27:56AM +0900, matsumur@....ricoh.co.jp wrote:
>> Dear Sir,
>> 
>> Ricoh 1180:e823 device is named R5U220/R5U232 (2 devices have the same
>> device ID ).
>> So, I think it should be declared to as PCI_DEVICE_ID_RICOH_R5U220.
>
> Is that just the wrong name or will it actually cause misfunction?

I don't think it could possibly cause misfunction; it's just a macro name.

> BTW, does anyone know whether the current SDHCI-driver sets 200Mhz to
> SD-CLK for UHS-I cards ?

The Linux 3.1 SD driver will set the SD-CLK to 50MHz for every card on an
e823 device, and older kernels will do so too once the commit has been
applied to the stable trees.  See this commit:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=15bed0f2fa8e1d7db201692532c210a7823d2d21

Do you know of a better solution than always lowering the clock speed to
50MHz for this controller?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/