linux-kernel - [PATCH -next] usercopy: Fixup patch to commit 4df97ff66a102a89ecfa2f88051e30bdd54ad864

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2011 20:58:12 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>, x86@...nel.org,
	Ingo Molnar <mingo@...e.hu>, Arnd Bergmann <arnd@...db.de>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de
Cc:	Sedat Dilek <sedat.dilek@...il.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH -next] usercopy: Fixup patch to commit 4df97ff66a102a89ecfa2f88051e30bdd54ad864

When building with CONFIG_BINFMT_MISC=m linux-next (next-20110728) breaks:
ERROR: "copy_from_user_overflow" [fs/binfmt_misc.ko] undefined!

The issue was introduced by commit ab3b49d018924085e5d949c1af53fae0da9a8d94:
"The help text for this config is duplicated across the x86, parisc, and s390 Kconfig.debug files."

After reporting the issue to linux-next/LKML mailing-lists, Stephen Boyd
told me he had already sent a fix [1] which should be folded into [2].
Unfortunately, Stephen's fixup didn't get into Andrew's mmotm-tree and
find its way from there to linux-next.

Tested on x86_64 (Randy) and i386 (Sedat).

[1] https://lkml.org/lkml/2011/7/6/6
[2] http://userweb.kernel.org/~akpm/mmotm/broken-out/consolidate-config_debug_strict_user_copy_checks.patch

Reported-by: Randy Dunlap <rdunlap@...otime.net>
Reported-by: Sedat Dilek <sedat.dilek@...il.com>
Tested-by: Randy Dunlap <rdunlap@...otime.net>
Tested-by: Sedat Dilek <sedat.dilek@...il.com>
Cc: Stephen Boyd <sboyd@...eaurora.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
---
 lib/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile b/lib/Makefile
index fbf4b06..4ac9e49b 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -14,7 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
 	 proportions.o prio_heap.o ratelimit.o show_mem.o \
 	 is_single_threaded.o plist.o decompress.o find_next_bit.o
 
-lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
+obj-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
 lib-$(CONFIG_MMU) += ioremap.o
 lib-$(CONFIG_SMP) += cpumask.o
 
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/