linux-kernel - Re: linux-next: Tree for July 28 ("copy_from_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2011 20:59:32 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Helge Deller <deller@....de>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: linux-next: Tree for July 28 ("copy_from_user_overflow" undefined)

On Fri, Jul 29, 2011 at 8:21 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> On Fri, 29 Jul 2011 10:50:37 -0700 Stephen Boyd wrote:
>
>> On 07/29/2011 02:45 AM, Sedat Dilek wrote:
>> > [ CCing all people from 0416 patch ]
>> >
>> > OK, here a quick review and looking for suspicious commits:
>> [snip]
>> > -- a/lib/Makefile
>> > +++ b/lib/Makefile
>> > @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
>> >          proportions.o prio_heap.o ratelimit.o show_mem.o \
>> >          is_single_threaded.o plist.o decompress.o find_next_bit.o
>> >
>> > +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
>> >  lib-$(CONFIG_MMU) += ioremap.o
>> >  lib-$(CONFIG_SMP) += cpumask.o
>> >
>> > So, I can rebuild next-201107{27,28} with
>> > CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the
>> > build-breakage in binfmt_misc is gone.
>> >
>> > Any comments from x86 folk?
>>
>> I already noticed this and sent a fixup patch to Andrew. Looks like he
>> never picked it up. The real fix is to change that lib-$(CONFIG... to
>> obj-$(CONFIG...
>>
>> See https://lkml.org/lkml/2011/7/6/6 for the patch.
>
> Thanks, that works.
>
> Adding Andrew to cc list.
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>

I have sent out a separate patch on top of today's linux-next.
Have fun!

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/