[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPXgP113jUZnUEH9tWwzgY37wwfQebPnYbVmUpJx9Mfu=MRJ6A@mail.gmail.com>
Date: Sat, 30 Jul 2011 21:03:30 +0200
From: Kay Sievers <kay.sievers@...y.org>
To: Tejun Heo <tj@...nel.org>
Cc: Jens Axboe <jaxboe@...ionio.com>, Karel Zak <kzak@...hat.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] loop: add management interface for on-demand device allocation
On Thu, Jul 28, 2011 at 13:18, Kay Sievers <kay.sievers@...y.org> wrote:
> On Thu, Jul 28, 2011 at 12:17, Tejun Heo <tj@...nel.org> wrote:
>> On Tue, Jul 26, 2011 at 01:50:30PM +0200, Kay Sievers wrote:
>>> From: Kay Sievers <kay.sievers@...y.org>
>>> Subject: loop: add management interface for on-demand device allocation
>>>
>>> Loop devices today have a fixed pre-allocated number of usually 8.
>>> The number can only be changed at init time. To find a free device
>>> to use, /dev/loop%i needs to be scanned and all devices need to be
>>> opened.
>>
>> It generally looks good to me but I really hope it were split into
>> multiple patches. I think it's a bit too big and doing too many
>> different things. Can you please split it up?
>
> Hmm, split into what? Like splitting the loop-control stuff off? The
> rest can't really be split I guess, because all the linked lists need
> to be converted to idr at once.
Split it into 3 pieces, which I'll send now.
Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists