linux-kernel - Re: [PATCH -next] sfi: sfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLq85O93Wa-_A98y6=CV1k-CwyqVxwXUqNVfhkUd9Oz1Cw@mail.gmail.com>
Date:	Sat, 30 Jul 2011 15:05:45 -0400
From:	Paul Gortmaker <paul.gortmaker@...il.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, lenb@...nel.org,
	sfi-devel@...plefirmware.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] sfi: sfi_acpi.c needs sysfs.h

On Fri, Jul 29, 2011 at 9:09 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> From: Randy Dunlap <rdunlap@...otime.net>
>
> sfi_acpi.c needs to include linux/sysfs.h for data types.

Applied to module.h-split, thanks.

P.

>
> drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
> drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
> drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type
>
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> ---
>  drivers/sfi/sfi_core.h |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- linux-next-20110729.orig/drivers/sfi/sfi_core.h
> +++ linux-next-20110729/drivers/sfi/sfi_core.h
> @@ -55,6 +55,9 @@
>   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
>  */
> +
> +#include <linux/sysfs.h>
> +
>  struct sfi_table_key{
>        char    *sig;
>        char    *oem_id;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/