linux-kernel - Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110731033916.GA7182@[192.168.0.12]>
Date:	Sat, 30 Jul 2011 21:41:11 -0600
From:	Adam Cozzette <acozzette@...hmc.edu>
To:	Justin Piszcz <jpiszcz@...idpixels.com>
Cc:	Andreas Hartmann <andihartmann@...19freenet.de>,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Ivo van Doorn <IvDoorn@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	Alan Piszcz <ap@...arrain.com>, users@...x00.serialmonkey.com
Subject: Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

On Sat, Jul 30, 2011 at 01:10:26PM -0400, Justin Piszcz wrote:
> (This is with the patch provided earlier)
> 
> atom:/usr/src/linux# cd drivers/net/wireless/rt2x00/
> atom:/usr/src/linux/drivers/net/wireless/rt2x00# grep 'memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE)' rt2800lib.c
>         memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE);
> atom:/usr/src/linux/drivers/net/wireless/rt2x00# cat /usr/src/linux/.version
> 2
> atom:/usr/src/linux/drivers/net/wireless/rt2x00# uname -a
> Linux atom 3.0.0 #2 SMP Sat Jul 30 08:34:18 EDT 2011 x86_64 GNU/Linux
> atom:/usr/src/linux/drivers/net/wireless/rt2x00#
> 
> Justin.

The last two images you posted show rt2800_txdone in the stack trace. I couldn't
find any such function in the source and unless I'm mistaken, it was renamed in
commit 8f66bbb5 back in May. Are you sure that the most recent code is what is
actually running when you run into this problem?

-- 
Adam Cozzette
Harvey Mudd College
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/