linux-kernel - Re: [PATCH v2 1/5] firmware: Add DMI entry types to the headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC-0EqjA_9QKZOGbmYL0A2-xKWxycU1bY59dJERB6_rGRpQR2g@mail.gmail.com>
Date:	Sat, 30 Jul 2011 22:11:09 -0600
From:	David Hubbard <david.c.hubbard@...il.com>
To:	Mike Waychison <mikew@...gle.com>
Cc:	Linux kernel <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH v2 1/5] firmware: Add DMI entry types to the headers

Hi Mike,

>>> In preparation for the upcoming commits, introduce the DMI entry types to
>>> the headers.  These type names are based on those specified in the DMTF
>>> SMBIOS specification version 2.7.1.
>>>
>>> Signed-off-by: Mike Waychison <mikew@...gle.com>
>>> ---
>>>  include/linux/dmi.h |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 files changed, 47 insertions(+), 0 deletions(-)
>>
>> I noticed a missing entry w.r.t. dmi_smbios_structure_type() in dmidecode.c:
>>
>> --- include/linux/dmi.h 2011-07-24 17:14:34.000000000 -0600
>> +++ include/linux/dmi.h 2011-07-24 17:14:49.000000000 -0600
>> @@ -57,6 +57,7 @@
>>        DMI_ENTRY_OOB_REMOTE_ACCESS,
>>        DMI_ENTRY_BIS_ENTRY,
>>        DMI_ENTRY_SYSTEM_BOOT,
>> +       DMI_ENTRY_64_MEM_ERROR,
>>        DMI_ENTRY_MGMT_DEV,
>>        DMI_ENTRY_MGMT_DEV_COMPONENT,
>>        DMI_ENTRY_MGMT_DEV_THRES,
>
> Good catch.  Looks like I screwed this up when transcribing the types
> from the docs.   Good thing nobody depends on these later enums yet ;)
>
> Can you post a patch in the canonical format specified in
> Documentation/SubmittingPatches ?
>

Gmail makes it unnecessarily complicated, converting tabs to spaces.
Here's my attempt. If the in-body patch fails, below, I have attached
it as well as a backup.


Add a missing DMI type (DMI_ENTRY_64_MEM_ERROR).

Patch is against 2.6.39. I can resubmit against the latest git tree if
the patch doesn't apply cleanly.

Signed-off-by: David Hubbard <david.c.hubbard@...il.com>

--- include/linux/dmi.h.2.6.39	2011-07-30 22:06:05.000000000 -0600
+++ include/linux/dmi.h	2011-07-30 22:06:39.000000000 -0600
@@ -57,6 +57,7 @@ enum dmi_entry_type {
 	DMI_ENTRY_OOB_REMOTE_ACCESS,
 	DMI_ENTRY_BIS_ENTRY,
 	DMI_ENTRY_SYSTEM_BOOT,
+	DMI_ENTRY_64_MEM_ERROR,
 	DMI_ENTRY_MGMT_DEV,
 	DMI_ENTRY_MGMT_DEV_COMPONENT,
 	DMI_ENTRY_MGMT_DEV_THRES,

View attachment "firmware_add_missing_entry_type.patch.txt" of type "text/plain" (354 bytes)