linux-kernel - Re: [PATCH 18/18] dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling kfree() directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=ng=wceMtLw21jw1QF_h_zeafNCdp3EYMVxm_nvchL_yg@mail.gmail.com>
Date:	Sat, 30 Jul 2011 22:39:03 -0700
From:	viresh kumar <viresh.linux@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Viresh Kumar <viresh.kumar@...com>, vinod.koul@...el.com,
	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	armando.visconti@...com, shiraz.hashim@...com, vipin.kumar@...com,
	rajeev-dlh.kumar@...com, deepak.sikri@...com,
	vipulkumar.samar@...com, amit.virdi@...com, pratyush.anand@...com,
	bhupesh.sharma@...com
Subject: Re: [PATCH 18/18] dmaengine/amba-pl08x: Call pl08x_free_txd() instead
 of calling kfree() directly

On 7/30/11, Linus Walleij <linus.walleij@...aro.org> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar@...com>:
>
>> pl08x_prep_channel_resources() is calling kfree() directly for txd(). To
>> maintain consistency in code call pl08x_free_txd() instead.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
>
> Good idea,
> Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yet there is a problem with this patch, as pointed by Russell.
pl08x_free_txd() must be called with channel lock taken. Will
check what can be done here.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/