linux-kernel - Re: [PATCH] Staging: cx25821: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312215262.11635.15.camel@Joe-Laptop>
Date:	Mon, 01 Aug 2011 09:14:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Leonid V. Fedorenchik" <leonidsbox@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org, mchehab@...hat.com,
	arnd@...db.de, linux-kernel@...r.kernel.org,
	Palash.Bandyopadhyay@...exant.com, ruslan@...sarev.org.ua,
	Revent82@...il.com
Subject: Re: [PATCH] Staging: cx25821: fix coding style issues

On Mon, 2011-08-01 at 17:33 +0800, Leonid V. Fedorenchik wrote:
> Fix too long lines in cx25821-audio.h and cx25821-core.c
[]
> diff --git a/drivers/staging/cx25821/cx25821-core.c b/drivers/staging/cx25821/cx25821-core.c
[]
> @@ -972,8 +972,8 @@ static int cx25821_dev_setup(struct cx25821_dev *dev)
>  	dev->lmmio = ioremap(dev->base_io_addr, pci_resource_len(dev->pci, 0));
>  
>  	if (!dev->lmmio) {
> -		CX25821_ERR
> -		    ("ioremap failed, maybe increasing __VMALLOC_RESERVE in page.h\n");
> +		CX25821_ERR("ioremap failed, maybe increasing __VMALLOC_RESERVE"
> +								" in page.h\n");

Please do not split formats.

>  		cx25821_iounmap(dev);
>  		return -ENOMEM;
>  	}
> @@ -1011,8 +1011,8 @@ static int cx25821_dev_setup(struct cx25821_dev *dev)
>  	if (video_register_device
>  	    (dev->ioctl_dev, VFL_TYPE_GRABBER, VIDEO_IOCTL_CH) < 0) {
>  		cx25821_videoioctl_unregister(dev);
> -		pr_err("%s(): Failed to register video adapter for IOCTL, so unregistering videoioctl device\n",
> -		       __func__);
> +		pr_err("%s(): Failed to register video adapter for IOCTL, so "
> +				"unregistering videoioctl device\n", __func__);

This was better before the change.

> -static struct pci_device_id cx25821_pci_tbl[] = {
> +static DEFINE_PCI_DEVICE_TABLE(cx25821_pci_tbl) __used = {

__used?  Hard to believe that's necessary here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/