linux-kernel - Re: [PATCH RFC] mm: reverse lru scanning order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E36D110.30407@openvz.org>
Date:	Mon, 1 Aug 2011 20:15:12 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] mm: reverse lru scanning order

sorry, this patch is broken.

Konstantin Khlebnikov wrote:
> LRU scanning order was accidentially changed in commit v2.6.27-5584-gb69408e:
> "vmscan: Use an indexed array for LRU variables".
> Before that commit reclaimer always scan active lists first.
>
> This patch just reverse it back.
> This is just notice and question: "Does it affect something?"
>
> Signed-off-by: Konstantin Khlebnikov<khlebnikov@...nvz.org>
> ---
>   include/linux/mmzone.h |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index be1ac8d..88fb49c 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -141,7 +141,8 @@ enum lru_list {
>
>   #define for_each_lru(l) for (l = 0; l<  NR_LRU_LISTS; l++)
>
> -#define for_each_evictable_lru(l) for (l = 0; l<= LRU_ACTIVE_FILE; l++)
> +#define for_each_evictable_lru(l) \
> +	for (l = LRU_ACTIVE_FILE; l>= LRU_INACTIVE_ANON; l--)

there must be some thing like this:

+#define for_each_evictable_lru(l) \
+	for (l = LRU_ACTIVE_FILE; (int)l>= LRU_INACTIVE_ANON; l--)

otherwise gcc silently generates there infinite loop =)

>
>   static inline int is_file_lru(enum lru_list l)
>   {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/